Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

fix: Dragging the rows to re-order creates multiple duplicate items. #2243

Merged
merged 1 commit into from
Aug 27, 2019

Conversation

gijohn
Copy link
Contributor

@gijohn gijohn commented Aug 1, 2019

@openshift-ci-robot openshift-ci-robot added component/core Related to console core functionality size/XS Denotes a PR that changes 0-9 lines, ignoring generated files. labels Aug 1, 2019
@gijohn
Copy link
Contributor Author

gijohn commented Aug 1, 2019

/kind bug

@openshift-ci-robot openshift-ci-robot added the kind/bug Categorizes issue or PR as related to a bug. label Aug 1, 2019
@gijohn
Copy link
Contributor Author

gijohn commented Aug 1, 2019

/assign @christianvogt @spadgett

@gijohn
Copy link
Contributor Author

gijohn commented Aug 12, 2019

/assign @joshuawilson @rohitkrai03

@joshuawilson
Copy link
Contributor

@gijohn this is outside of dev console, only Christian can approve it or someone on the admin/core team can.

@joshuawilson
Copy link
Contributor

Can you please add to the description what you did and why.

@spadgett
Copy link
Member

We should open a Bugzilla to track this as this should be a release blocking bug. We also need to evaluate whether it's present in 4.1 to check if we need to backport.

Can you please add to the description what you did and why.

+1, it's unclear to me looking at the diff what the cause of the problem was. Can you describe what was wrong?

Thanks for your patience on the review.

@gijohn
Copy link
Contributor Author

gijohn commented Aug 16, 2019

@spadgett, @joshuawilson I don't see any problem with the data or the call to move method.

image
image

In the above example, the index of the first element is undefined and second is 1. It fails even if the indices are identical. i.e. 1 and 1.

image
image

It works fine when the index is populated correctly which acts as key. I believe it is a limitation from react-dnd.

@christianvogt
Copy link
Contributor

Tested this change out and I can no longer reproduce the issue of duplicating rows.

@christianvogt
Copy link
Contributor

/lgtm
/approve

@openshift-ci-robot openshift-ci-robot added the lgtm Indicates that a PR is ready to be merged. label Aug 27, 2019
@openshift-ci-robot
Copy link
Contributor

[APPROVALNOTIFIER] This PR is APPROVED

This pull-request has been approved by: christianvogt, gijohn

The full list of commands accepted by this bot can be found here.

The pull request process is described here

Needs approval from an approver in each of these files:

Approvers can indicate their approval by writing /approve in a comment
Approvers can cancel approval by writing /approve cancel in a comment

@openshift-ci-robot openshift-ci-robot added the approved Indicates a PR has been approved by an approver from all required OWNERS files. label Aug 27, 2019
@openshift-merge-robot openshift-merge-robot merged commit 96e8083 into openshift:master Aug 27, 2019
@gijohn gijohn deleted the fix-drag-reorder branch August 28, 2019 06:59
@spadgett spadgett added this to the v4.2 milestone Aug 30, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
approved Indicates a PR has been approved by an approver from all required OWNERS files. component/core Related to console core functionality kind/bug Categorizes issue or PR as related to a bug. lgtm Indicates that a PR is ready to be merged. size/XS Denotes a PR that changes 0-9 lines, ignoring generated files.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants