-
Notifications
You must be signed in to change notification settings - Fork 615
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
fix: Dragging the rows to re-order creates multiple duplicate items. #2243
fix: Dragging the rows to re-order creates multiple duplicate items. #2243
Conversation
/kind bug |
/assign @christianvogt @spadgett |
/assign @joshuawilson @rohitkrai03 |
@gijohn this is outside of dev console, only Christian can approve it or someone on the admin/core team can. |
Can you please add to the description what you did and why. |
We should open a Bugzilla to track this as this should be a release blocking bug. We also need to evaluate whether it's present in 4.1 to check if we need to backport.
+1, it's unclear to me looking at the diff what the cause of the problem was. Can you describe what was wrong? Thanks for your patience on the review. |
@spadgett, @joshuawilson I don't see any problem with the data or the call to move method. In the above example, the index of the first element is undefined and second is 1. It fails even if the indices are identical. i.e. 1 and 1. It works fine when the index is populated correctly which acts as key. I believe it is a limitation from react-dnd. |
Tested this change out and I can no longer reproduce the issue of duplicating rows. |
/lgtm |
[APPROVALNOTIFIER] This PR is APPROVED This pull-request has been approved by: christianvogt, gijohn The full list of commands accepted by this bot can be found here. The pull request process is described here
Needs approval from an approver in each of these files:
Approvers can indicate their approval by writing |
Fixes: https://jira.coreos.com/browse/ODC-1525